Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all rmm imports to use pylibrmm/librmm #6084

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Update all rmm imports to use pylibrmm/librmm #6084

merged 4 commits into from
Oct 8, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Sep 25, 2024

This PR updates all the RMM imports to use pylibrmm/librmm now that rmm._lib is deprecated . It should be merged after rmm/1676.

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Sep 25, 2024
@Matt711 Matt711 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 4, 2024
@Matt711 Matt711 marked this pull request as ready for review October 7, 2024 20:00
@Matt711 Matt711 requested a review from a team as a code owner October 7, 2024 20:00
@Matt711 Matt711 requested review from teju85 and wphicks October 7, 2024 20:00
@Matt711 Matt711 changed the title [WIP] Update all rmm imports to use pylibrmm/librmm Update all rmm imports to use pylibrmm/librmm Oct 7, 2024
dantegd
dantegd approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great!

@dantegd
Copy link
Member

dantegd commented Oct 8, 2024

/merge

@rapids-bot rapids-bot bot merged commit 61f85a6 into rapidsai:branch-24.12 Oct 8, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@teju85 teju85 Awaiting requested review from teju85 teju85 is a code owner automatically assigned from rapidsai/cuml-python-codeowners

@wphicks wphicks Awaiting requested review from wphicks wphicks is a code owner automatically assigned from rapidsai/cuml-python-codeowners

Assignees
No one assigned
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matt711 @dantegd