Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all-zeroes feature vectors for MG sparse logistic regression #6082

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Support all-zeroes feature vectors for MG sparse logistic regression #6082

merged 1 commit into from
Oct 1, 2024

Conversation

lijinf2
Copy link
Contributor

@lijinf2 lijinf2 commented Sep 25, 2024

No description provided.

@lijinf2 lijinf2 requested review from a team as code owners September 25, 2024 06:36
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 25, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@lijinf2 lijinf2 self-assigned this Sep 25, 2024
@github-actions github-actions bot added Cython / Python Cython or Python issue CUDA/C++ labels Sep 25, 2024
@lijinf2 lijinf2 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed Cython / Python Cython or Python issue labels Sep 25, 2024
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Sep 25, 2024
dantegd
dantegd approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change lgtm, will wait on other reviewers for a couple of days to see if they see any issues with the approach.

@dantegd
Copy link
Member

dantegd commented Oct 1, 2024

/merge

@rapids-bot rapids-bot bot merged commit 9284ca3 into rapidsai:branch-24.10 Oct 1, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@cjnolet cjnolet Awaiting requested review from cjnolet cjnolet is a code owner automatically assigned from rapidsai/cuml-python-codeowners

@csadorf csadorf Awaiting requested review from csadorf csadorf is a code owner automatically assigned from rapidsai/cuml-python-codeowners

@teju85 teju85 Awaiting requested review from teju85 teju85 is a code owner automatically assigned from rapidsai/cuml-cpp-codeowners

Assignees

@lijinf2 lijinf2

Labels
CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lijinf2 @dantegd