Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default values for conftest options. #6067

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Set default values for conftest options. #6067

merged 2 commits into from
Sep 12, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Sep 11, 2024

There is no default being set for run_ucx or run_ucxx. This results in an error on Python 3.12 (maybe other versions too):

AttributeError: 'Namespace' object has no attribute 'run_ucx'. Did you mean: 'run_unit'?

This PR adds a default value for those conftest options.

@bdice bdice requested a review from a team as a code owner September 11, 2024 15:47
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Sep 11, 2024
@bdice bdice self-assigned this Sep 11, 2024
@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Sep 11, 2024
@bdice
Copy link
Contributor Author

bdice commented Sep 12, 2024

/merge

@rapids-bot rapids-bot bot merged commit cd19b30 into rapidsai:branch-24.10 Sep 12, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

Assignees

@bdice bdice

Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @divyegala