Fix segfault and other errors in ForestInference.load_from_sklearn #5973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
commented
Jul 24, 2024
| @@ -557,15 +557,15 @@ cdef class ForestInference_impl(): | |||
| def __dealloc__(self): | |||
| cdef handle_t* handle_ = <handle_t*><size_t>self.handle.getHandle() | |||
| fil_dtype = self.get_dtype() | |||
There was a problem hiding this comment.
This line was causing troubles, as modules may have been unloaded by the Python interpreter by the time the __dealloc__ method is called. When I inserted a print(np) statement here, it yielded None.
hcho3
changed the title
|
/merge |
dantegd
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5551
np.float32with"float32"so that we don't reference thenpmodule. By the time__dealloc__method is called, modules may have already been unloaded.