Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent undefined behavior when passing handle from Treelite to cuML FIL #5849

Merged
merged 9 commits into from
Apr 20, 2024
Merged

Prevent undefined behavior when passing handle from Treelite to cuML FIL #5849

merged 9 commits into from
Apr 20, 2024

Commits on Apr 16, 2024

  1. Prevent undefined behavior when passing handle from Treelite to cuML FIL

    @hcho3
    hcho3 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    761c06f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/branch-24.06' into fix_fil_tests

    @hcho3
    hcho3 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    60e9d85 View commit details
    Browse the repository at this point in the history

  3. Re-enable FIL tests

    @hcho3
    hcho3 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    a314c1a View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: jakirkham <[email protected]>
    @hcho3 @jakirkham
    hcho3 and jakirkham authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    86079d8 View commit details
    Browse the repository at this point in the history

  5. Add more typing 

    Co-authored-by: jakirkham <[email protected]>
    @hcho3 @jakirkham
    hcho3 and jakirkham committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9d8f158 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Improve formatting for errors 

    Co-authored-by: jakirkham <[email protected]>
    @hcho3 @jakirkham
    hcho3 and jakirkham committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    0e15e16 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/branch-24.06' into fix_fil_tests

    @hcho3
    hcho3 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    a7b38ed View commit details
    Browse the repository at this point in the history

  3. Apply the same fix to experimental FIL

    @hcho3
    hcho3 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    fb90c97 View commit details
    Browse the repository at this point in the history

  4. Prevent memory leak

    @hcho3
    hcho3 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    6297d8f View commit details
    Browse the repository at this point in the history