Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO MRG] Test CUDA 12.2 ARM #5719

Closed
wants to merge 7 commits into from

Conversation

jakirkham
Copy link
Member

cc @dantegd @bdice (for vis)

@jakirkham jakirkham added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 17, 2024
@jakirkham jakirkham changed the title [NO MRG] Test cuda 12.2 arm [NO MRG] Test CUDA 12.2 ARM Jan 17, 2024
@jakirkham jakirkham added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Jan 17, 2024
@bdice
Copy link
Contributor

bdice commented Jan 17, 2024

A couple tests failed, in nearest neighbors rbc. @dantegd Do these look flaky or like real errors? https://github.com/rapidsai/cuml/actions/runs/7550203817/job/20556793932?pr=5719#step:7:2209

=========================== short test summary info ============================
FAILED test_nearest_neighbors.py::test_nearest_neighbors_rbc[10000-4-distance_dims2] - assert 61 == 0
 +  where 61 = len(array([0.03404859, 0.05077938, 0.0466364 , 0.03432905, 0.04402662,\n       0.03807753, 0.03931149, 0.05083709, 0.042646...5303, 0.05475897,\n       0.04552774, 0.01488325, 0.04743127, 0.03355303, 0.03736537,\n       0.055514  ], dtype=float32))
FAILED test_nearest_neighbors.py::test_nearest_neighbors_rbc[10000-25-distance_dims2] - assert 3063 == 0
 +  where 3063 = len(array([0.08589244, 0.06178145, 0.09209934, ..., 0.09683452, 0.12032759,\n       0.055514  ], dtype=float32))
= 2 failed, 13253 passed, 6084 skipped, 634 xfailed, 54 xpassed, 2824 warnings in 2008.89s (0:33:28) =

I’ll rerun to see if it is reproducible.

@bdice
Copy link
Contributor

bdice commented Jan 17, 2024

The failures seen here seem unrelated to the GPUTreeShap update, so I am going to request an admin-merge of rapidsai/gputreeshap#42.

@bdice
Copy link
Contributor

bdice commented Jan 17, 2024

The GPUTreeShap fix has been merged. I updated the commit in #5711 to point to the latest gputreeshap 9d32df85f822f186b5fbf53a9a1fa0251d0cd755, so we can close this.

@bdice bdice closed this Jan 17, 2024
@jakirkham jakirkham deleted the test-cuda-12.2-arm branch January 17, 2024 19:07
@jakirkham
Copy link
Member Author

Thanks for following up Bradley! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - DO NOT MERGE Hold off on merging; see PR for details CMake conda conda issue CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants