Enable Dask tests with UCX-Py/UCXX in CI #5697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantegd
added
improvement
rapids-bot bot
pushed a commit
to rapidsai/raft
that referenced
this pull request
May 8, 2024
As figured out in rapidsai/cuml#5697, `libucx` should not be just a testing dependency of `raft-dask`, it should be a run dependency. cc @vyasr Authors: - Divye Gala (https://github.com/divyegala) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Dante Gama Dessavre (https://github.com/dantegd) - Ray Douglass (https://github.com/raydouglass) URL: #2296
abc99lr
pushed a commit
to abc99lr/raft
that referenced
this pull request
May 10, 2024
As figured out in rapidsai/cuml#5697, `libucx` should not be just a testing dependency of `raft-dask`, it should be a run dependency. cc @vyasr Authors: - Divye Gala (https://github.com/divyegala) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Dante Gama Dessavre (https://github.com/dantegd) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#2296
pentschev
changed the title
jameslamb
reviewed
May 16, 2024
divyegala
reviewed
May 17, 2024
|
|
||
| n_neighbors = 10 | ||
| n_clusters = 5 | ||
| from cuml.dask.neighbors import NearestNeighbors as daskNN | ||
|
|
||
| from sklearn.datasets import make_blobs | ||
|
|
||
| print("_scale_rows", flush=True) |
There was a problem hiding this comment.
These should be removed, right?
There was a problem hiding this comment.
Great catch, not sure how I missed it. Done in ce9590a .
AyodeAwe
approved these changes
May 17, 2024
divyegala
approved these changes
May 17, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Dask tests in CI with TCP/UCX-Py/UCXX comms. The heavy-lifting is entirely done in
raft-dask, so no functional changes are required incuml