Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for timeouts in tests #5598

Merged
merged 5 commits into from
Oct 4, 2023

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Oct 2, 2023

Timeouts in CI were happening due to CUDA context creation happening in some dask estimator docstrings, this PR fixes that by avoiding that context creation.

Also fixes a typo in the coordinate descent solver that caused the intercept to be calculated wrong in some cases

@dantegd dantegd requested a review from a team as a code owner October 2, 2023 20:01
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Oct 2, 2023
python/cuml/internals/available_devices.py Outdated Show resolved Hide resolved
python/cuml/internals/available_devices.py Outdated Show resolved Hide resolved
@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Oct 3, 2023
@@ -296,7 +296,7 @@ class CD(Base,
<double>self.tol,
<double*>sample_weight_ptr)

self.intercept_ = _c_intercept2_f64
self.intercept_ = _c_intercept2_f64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated fix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it just seemed way to small of a change to warrant a full PR with CI run

@dantegd
Copy link
Member Author

dantegd commented Oct 4, 2023

/merge

@rapids-bot rapids-bot bot merged commit 2299144 into rapidsai:branch-23.10 Oct 4, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants