Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing RAFT cusolver_macros import and changes for recent cuDF updates #5434

Merged
merged 18 commits into from
May 26, 2023
Merged

Add missing RAFT cusolver_macros import and changes for recent cuDF updates #5434

merged 18 commits into from
May 26, 2023

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented May 23, 2023 •
edited by bdice
Loading

This PR:

@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels May 23, 2023
@dantegd dantegd requested a review from a team as a code owner May 23, 2023 20:49
@dantegd dantegd changed the title Add missing RAFT cusolver_wrappers import in csr.cuh Add missing RAFT cusolver_macros import in csr.cuh May 23, 2023
@bdice bdice mentioned this pull request May 23, 2023
Closed
@dantegd dantegd requested a review from a team as a code owner May 24, 2023 15:06
@github-actions github-actions bot added the Cython / Python Cython or Python issue label May 24, 2023
@ayushdg ayushdg mentioned this pull request May 24, 2023
Merged
@isVoid isVoid mentioned this pull request May 24, 2023
Merged
3 tasks
@dantegd dantegd changed the title Add missing RAFT cusolver_macros import in csr.cuh Add missing RAFT cusolver_macros import and changes for recent cuDF updates May 24, 2023
@bdice
Copy link
Contributor

bdice commented May 25, 2023 •
edited
Loading

Notebook tests are failing because the cudf and libcudf are mismatched.

cudf                      23.06.00a       cuda11_py310_230523_g4fdb60de7f_224    rapidsai-nightly
libcudf                   23.06.00a       cuda11_230525_g03f0c0cbd1_238          rapidsai-nightly

The error is:

ImportError: /opt/conda/envs/test/lib/python3.10/site-packages/cudf/_lib/column.cpython-310-x86_64-linux-gnu.so: undefined symbol: _ZNK4cudf6detail16column_view_base10null_countEv

I'll try to identify the cause here.

edit: should be fixed by the updated numba>=0.57 pinning in 8100b5d.

@dantegd dantegd requested a review from a team as a code owner May 25, 2023 16:53
@github-actions github-actions bot added ci conda conda issue labels May 25, 2023
@charlesbluca charlesbluca mentioned this pull request May 25, 2023
Merged
ajschmidt8
ajschmidt8 approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@rlratzel rlratzel mentioned this pull request May 25, 2023
Closed
@dantegd
Copy link
Member Author

dantegd commented May 26, 2023

/merge

@rapids-bot rapids-bot bot merged commit c304ec8 into rapidsai:branch-23.06 May 26, 2023
@bdice
Copy link
Contributor

bdice commented May 26, 2023

Thanks for your help on this @dantegd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@wphicks wphicks wphicks approved these changes

@divyegala divyegala divyegala approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ci conda conda issue CUDA/C++ Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dantegd @bdice @ajschmidt8 @wphicks @divyegala