Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Modify default batch size in HDBSCAN soft clustering #5335

Merged
merged 53 commits into from
Apr 6, 2023
Merged

[FEA] Modify default batch size in HDBSCAN soft clustering #5335

merged 53 commits into from
Apr 6, 2023

Conversation

tarang-jain
Copy link
Contributor

Default batch size is changed in HDBSCAN soft clustering to avoid CUDA OOM errors in. large datasets.

tarang-jain and others added 30 commits February 17, 2023 17:18
@tarang-jain
membership_vector initial commit
e49d06a
@tarang-jain
Further updates to membership_vector
436b180
@tarang-jain
Merge branch 'branch-23.04' into fea-membership-vector
48030b8
@tarang-jain
Initial testing membership_vector
7912dba
@tarang-jain
Debug statements
4b41edb
@tarang-jain
Merge branch 'fea-membership-vector' of https://github.com/tarang-jai…
fe0fd34 
…n/cuml into fea-membership-vector
@tarang-jain
debugging membership_vector
9d5badc
@tarang-jain
membership_vector first working impl
19f9dd8
@tarang-jain
GoogleTest intermediate commit
a4b565c
@tarang-jain
GTest working
1f4bf78
@tarang-jain
working tests and styling changes
fdf100b
@tarang-jain
replace with raft mdspan primitives and add FastIntDiv
e18096a
@tarang-jain
Merge branch 'branch-23.04' into fea-membership-vector
c2aa77e
@tarang-jain
cpu support
182ba31
@tarang-jain
Fix failing pytest
366ef26
@tarang-jain
Merge branch 'branch-23.04' into fea-membership-vector
b60d869
@tarang-jain
modification after merge
6bfaae2
@tarang-jain
Update softmax with raft::linalg reduction
c4e0bf1
@tarang-jain
Remove sync stream
fb634e4
@tarang-jain
memory study commit (to be reversed)
a49ba87
@tarang-jain
Merge branch 'branch-23.04' of github.com:rapidsai/cuml into fea-memb…
4ed9fd7 
…ership-vector
@tarang-jain
first commit (working)
d1712c0
@tarang-jain
set batch_size as an arg
f41416a
@tarang-jain
Merge branch 'branch-23.04' of github.com:rapidsai/cuml into fea-new-…
333077a 
…reduce-memory-pressure-apmv
@tarang-jain
working build, styling changes
71217e2
@tarang-jain
batch_size added to membership_vector
bdaefa5
@tarang-jain
Merge branch 'branch-23.04' of github.com:rapidsai/cuml into fea-new-…
04e76cb 
…reduce-memory-pressure-apmv
@tarang-jain
Style fix
fa7b44e
@tarang-jain
Merge branch 'branch-23.04' of github.com:rapidsai/cuml into fea-memb…
45f8ca4 
…ership-vector
@tarang-jain
Remove print debug statements
367de04
tarang-jain and others added 17 commits March 20, 2023 13:01
@tarang-jain
Merge branch 'branch-23.04' into fea-membership-vector
98aa237
@tarang-jain
Merge branch 'branch-23.04' into fea-new-reduce-memory-pressure-apmv
3a38769
@tarang-jain
Merge branch 'branch-23.04' into fea-membership-vector
d387026
@tarang-jain
Updates after PR reviews
ed40e22
@tarang-jain
Merge branch 'fea-membership-vector' of https://github.com/tarang-jai…
387cde8 
…n/cuml into fea-membership-vector
@tarang-jain
Merge branch 'branch-23.04' of github.com:rapidsai/cuml into fea-memb…
092b3f8 
…ership-vector
@tarang-jain
Update height_argmax
ef85fd3
@tarang-jain
Intermediate merge commit
52eda5c
@tarang-jain
Merge branch 'branch-23.04' of github.com:rapidsai/cuml into fea-new-…
d8da560 
…reduce-memory-pressure-apmv
@tarang-jain
Update after merge membership_vector
7a95bfe
@tarang-jain
Updates after PR Reviews
dc92f90
@tarang-jain
Merge branch 'branch-23.04' of github.com:rapidsai/cuml into fea-new-…
615ad10 
…reduce-memory-pressure-apmv
@tarang-jain
Merge branch 'branch-23.04' into fea-new-reduce-memory-pressure-apmv
7b89484
@tarang-jain
Resolve merge conflicts
7f7f0a4
@tarang-jain
Merge branch 'branch-23.04' of github.com:rapidsai/cuml into fea-new-…
f37b05d 
…reduce-memory-pressure-apmv
@tarang-jain
Update default batch_size
e5ada81
@tarang-jain
Update docs
7335b73
@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels Apr 5, 2023
@tarang-jain tarang-jain added feature request New feature or request non-breaking Non-breaking change labels Apr 5, 2023
@tarang-jain tarang-jain marked this pull request as ready for review April 5, 2023 21:53
@tarang-jain tarang-jain requested review from a team as code owners April 5, 2023 21:53
@tarang-jain
Copy link
Contributor Author

rerun tests

@dantegd
Copy link
Member

dantegd commented Apr 6, 2023

/merge

@rapids-bot rapids-bot bot merged commit e0c37fa into rapidsai:branch-23.04 Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
CUDA/C++ Cython / Python Cython or Python issue feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarang-jain @dantegd @cjnolet