Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run experimental FIL tests in CI #5316

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Run experimental FIL tests in CI #5316

merged 1 commit into from
Mar 31, 2023

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Mar 31, 2023

No description provided.

@wphicks wphicks requested a review from a team as a code owner March 31, 2023 17:42
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 31, 2023
@wphicks
Copy link
Contributor Author

wphicks commented Mar 31, 2023

@hcho3 kindly pointed out that the experimental FIL tests were not being run in CI because this line was missing. Fortunately, we don't seem to have any failures in the branch where he added this fix, but this will ensure that we are correctly testing the new implementation.

@wphicks wphicks added bug Something isn't working non-breaking Non-breaking change labels Mar 31, 2023
@wphicks
Copy link
Contributor Author

wphicks commented Mar 31, 2023

/merge

@rapids-bot rapids-bot bot merged commit 356aed7 into rapidsai:branch-23.04 Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wphicks @dantegd