Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Treelite 3.2.0 #5304

Merged
merged 7 commits into from
Apr 4, 2023
Merged

Upgrade to Treelite 3.2.0 #5304

merged 7 commits into from
Apr 4, 2023

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Mar 27, 2023

Pick up new features implemented in Treelite, including:

  • predict_per_tree, predict_leaf in treelite.gtil
  • Ability to import Treelite models from JSON strings

@hcho3 hcho3 requested review from a team as code owners March 27, 2023 20:00
@github-actions github-actions bot added CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue labels Mar 27, 2023
@hcho3 hcho3 added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function and removed conda conda issue Cython / Python Cython or Python issue CMake CUDA/C++ labels Mar 27, 2023
@hcho3
Copy link
Contributor Author

hcho3 commented Mar 27, 2023

rerun tests

@hcho3 hcho3 closed this Mar 27, 2023
@hcho3 hcho3 reopened this Mar 27, 2023
@github-actions github-actions bot added CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue labels Mar 27, 2023
@hcho3 hcho3 closed this Mar 28, 2023
@hcho3 hcho3 reopened this Mar 28, 2023
@vyasr
Copy link
Contributor

vyasr commented Mar 28, 2023

@hcho3 assuming that the reason you're closing and reopening this PR is to trigger tests reruns, have a look at https://docs.github.com/en/actions/managing-workflow-runs/re-running-workflows-and-jobs. You can rerun jobs directly from the GUI in GHA. You an access it either using the Actions tab at the top of the page, or more specifically by clicking the Details links in the right column of the list of checks at the bottom of the PR.

@hcho3
Copy link
Contributor Author

hcho3 commented Mar 28, 2023

@vyasr I don't have the right to re-run jobs on GHA at this moment.

@hcho3
Copy link
Contributor Author

hcho3 commented Mar 29, 2023

Currently blocked by #5308

ajschmidt8
ajschmidt8 reviewed Mar 29, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A PR will need to also be opened to update treelite in the integration repository below.

@hcho3 hcho3 mentioned this pull request Mar 29, 2023
Merged
ajschmidt8
ajschmidt8 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes.

rapidsai/integration#629 should be merged at the same time as this PR.

@hcho3
Copy link
Contributor Author

hcho3 commented Mar 29, 2023

@dantegd Can we get this merged soon? It will be helpful in testing predict_per_tree and predict_leaf.

@raydouglass
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit eac8e7f into rapidsai:branch-23.04 Apr 4, 2023
@hcho3 hcho3 deleted the upgrade_treelite branch April 4, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hcho3 @vyasr @raydouglass @dantegd @ajschmidt8