Disable failing kernel ridge test #5181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wphicks
added
bug
cjnolet
approved these changes
Jan 30, 2023
dantegd
reviewed
Jan 31, 2023
Co-authored-by: Dante Gama Dessavre <[email protected]>
dantegd
reviewed
Jan 31, 2023
| @@ -178,6 +178,7 @@ def array_strategy(draw): | |||
|
|
|||
| @given(kernel_arg_strategy(), array_strategy()) | |||
| @settings(deadline=None) | |||
| @pytest.skip('https://github.com/rapidsai/cuml/issues/5177') | |||
There was a problem hiding this comment.
My suggestion was wrong, sorry for that, it should be @pytest.mark.skip (which I always confuse...)
Codecov ReportBase: 67.12% // Head: 67.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #5181 +/- ##
================================================
+ Coverage 67.12% 67.21% +0.08%
================================================
Files 192 192
Lines 12396 12370 -26
================================================
- Hits 8321 8314 -7
+ Misses 4075 4056 -19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Combined with #5194 to get them both to pass CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.