Remove faiss from libcuml
#5175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajschmidt8
added
improvement
raydouglass
approved these changes
Jan 27, 2023
|
/merge |
Codecov ReportBase: 69.26% // Head: 68.94% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #5175 +/- ##
================================================
- Coverage 69.26% 68.94% -0.33%
================================================
Files 192 192
Lines 12333 12396 +63
================================================
+ Hits 8543 8546 +3
- Misses 3790 3850 +60
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
benfred
added a commit
to benfred/cuml
that referenced
this pull request
Feb 15, 2023
This reverts commit f55f3ea.
benfred
added a commit
to benfred/cuml
that referenced
this pull request
Feb 21, 2023
This reverts commit 8e94af6.
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Feb 27, 2023
The version of `faiss` that's currently used by `libcuml` conflicts with the version used by `raft`. After discussions with @dantegd and @cjnolet, it was determined that `cuml` should really just depend on `raft`'s version of `faiss` anyway. Therefore, this PR removes `faiss` from `libcuml`. Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#5175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of
faissthat's currently used bylibcumlconflicts with the version used byraft.After discussions with @dantegd and @cjnolet, it was determined that
cumlshould really just depend onraft's version offaissanyway.Therefore, this PR removes
faissfromlibcuml.