build.sh switch to use RAPIDS magic value
#5124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapids-cmake 23.02 is deprecating the magic value of `ALL` since it doesn't cleanly map to the cmake magic value of `all`. Instead we use `RAPIDS` which better represents the architectures we are building for.
robertmaynard
added
bug
7 tasks
dantegd
approved these changes
Jan 10, 2023
Codecov ReportBase: 69.48% // Head: 69.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #5124 +/- ##
================================================
+ Coverage 69.48% 69.58% +0.09%
================================================
Files 192 192
Lines 12523 12523
================================================
+ Hits 8702 8714 +12
+ Misses 3821 3809 -12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/merge |
robertmaynard
deleted the
bug/remove-usage-of-deprecated-rapids-cmake-magic-value
branch
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Feb 27, 2023
rapids-cmake 23.02 is deprecating the magic value of `ALL` since it doesn't cleanly map to the cmake magic value of `all`. Instead we use `RAPIDS` which better represents the architectures we are building for. Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#5124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rapids-cmake 23.02 is deprecating the magic value of
ALLsince it doesn't cleanly map to the cmake magic value ofall. Instead we useRAPIDSwhich better represents the architectures we are building for.