Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all CPU/GPU only imports "safe" for respective package #5117

Merged
merged 6 commits into from
Jan 9, 2023
Merged

Make all CPU/GPU only imports "safe" for respective package #5117

merged 6 commits into from
Jan 9, 2023

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Jan 6, 2023

No description provided.

@wphicks wphicks requested review from a team as code owners January 6, 2023 01:25
@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels Jan 6, 2023
@wphicks wphicks added feature request New feature or request non-breaking Non-breaking change labels Jan 6, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 69.33% // Head: 69.48% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (5df5d16) compared to base (0303a93).
Patch coverage: 79.21% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-23.02    #5117      +/-   ##
================================================
+ Coverage         69.33%   69.48%   +0.14%     
================================================
  Files               192      192              
  Lines             12377    12523     +146     
================================================
+ Hits               8581     8701     +120     
- Misses             3796     3822      +26
Impacted Files Coverage Δ
python/cuml/benchmark/automated/utils/utils.py 0.00% <0.00%> (ø)
python/cuml/benchmark/ci_benchmark.py 0.00% <0.00%> (ø)
python/cuml/benchmark/run_benchmarks.py 0.00% <0.00%> (ø)
python/cuml/common/numba_utils.py 0.00% <0.00%> (ø)
python/cuml/preprocessing/onehotencoder_mg.py 0.00% <0.00%> (ø)
python/cuml/testing/dask/utils.py 0.00% <0.00%> (ø)
python/cuml/dask/ensemble/base.py 20.44% <20.44%> (+0.88%) ⬆️
python/cuml/dask/common/utils.py 28.84% <69.23%> (+0.69%) ⬆️
...party/sklearn/preprocessing/_column_transformer.py 74.93% <100.00%> (+0.18%) ⬆️
...on/cuml/_thirdparty/sklearn/preprocessing/_data.py 90.16% <100.00%> (+0.04%) ⬆️
... and 68 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dantegd
Copy link
Member

dantegd commented Jan 9, 2023

/merge

@rapids-bot rapids-bot bot merged commit 199c7d4 into rapidsai:branch-23.02 Jan 9, 2023
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@wphicks
Make all CPU/GPU only imports "safe" for respective package (rapidsai…
3c40d01 
…#5117)

Authors:
  - William Hicks (https://github.com/wphicks)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#5117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
CUDA/C++ Cython / Python Cython or Python issue feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wphicks @codecov-commenter @dantegd