Reduce Naive Bayes test time #5082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wphicks
approved these changes
Dec 13, 2022
lowener
added
improvement
|
rerun tests |
|
@gpucibot merge |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #5082 +/- ##
===============================================
Coverage ? 78.96%
===============================================
Files ? 192
Lines ? 12377
Branches ? 0
===============================================
Hits ? 9773
Misses ? 2604
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Feb 27, 2023
Linking rapidsai#5053 The number of columns is now reduced, a few similar tests are grouped together, to avoid fitting multiple time the same model on the same data. This results in time and memory usage reduction. On my local machine the speedup is of x1.84, the duration goes from 142.79s (0:02:22) to 77.05s (0:01:17). Authors: - Micka (https://github.com/lowener) - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - William Hicks (https://github.com/wphicks) URL: rapidsai#5082
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking #5053
The number of columns is now reduced, a few similar tests are grouped together, to avoid fitting multiple time the same model on the same data. This results in time and memory usage reduction.
On my local machine the speedup is of x1.84, the duration goes from 142.79s (0:02:22) to 77.05s (0:01:17).