Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose text, text.{CountVectorizer,HashingVectorizer,Tfidf{Transformer,Vectorizer}} from feature_extraction's public api #5028

Merged
merged 2 commits into from
Dec 17, 2022

Conversation

mattf
Copy link
Contributor

@mattf mattf commented Nov 25, 2022

No description provided.

…r,Vectorizer}} from feature_extraction's public api
@mattf mattf requested a review from a team as a code owner November 25, 2022 15:05
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Nov 25, 2022
@csadorf
Copy link
Contributor

csadorf commented Nov 29, 2022

@mattf Is this a hotfix or should it be targeting branch-23.02 ?

@mattf
Copy link
Contributor Author

mattf commented Nov 29, 2022

@csadorf i don’t think this is a hotfix. this is on 22.12 because the default branch is branch-22.12.

@csadorf
Copy link
Contributor

csadorf commented Nov 29, 2022

@csadorf i don’t think this is a hotfix. this is on 22.12 because the default branch is branch-22.12.

Got it. 👍🏻 cuml is already in the burn down stage, so I'd suggest to target branch-23.02.

@mattf mattf changed the base branch from branch-22.12 to branch-23.02 November 29, 2022 11:23
@mattf
Copy link
Contributor Author

mattf commented Nov 29, 2022

@csadorf the ci failures look unrelated to this pr

@csadorf
Copy link
Contributor

csadorf commented Nov 29, 2022

@csadorf the ci failures look unrelated to this pr

Indeed, I am currently trying to fix that in #5030 .

@beckernick beckernick added doc Documentation non-breaking Non-breaking change labels Nov 29, 2022
@csadorf
Copy link
Contributor

csadorf commented Dec 7, 2022

rerun tests

@dantegd
Copy link
Member

dantegd commented Dec 8, 2022

@gpucibot merge

@dantegd
Copy link
Member

dantegd commented Dec 8, 2022

rerun tests

@dantegd
Copy link
Member

dantegd commented Dec 8, 2022

Same comment as PR #5034, for some reason the branch checker job is stuck in a couple of PRs, will work on solving that or admin merging later today

@dantegd dantegd added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Dec 8, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 79.38% // Head: 79.83% // Increases project coverage by +0.44% 🎉

Coverage data is based on head (fcc4a03) compared to base (81621d2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02    #5028      +/-   ##
================================================
+ Coverage         79.38%   79.83%   +0.44%     
================================================
  Files               184      185       +1     
  Lines             11707    11728      +21     
================================================
+ Hits               9294     9363      +69     
+ Misses             2413     2365      -48     
Flag Coverage Δ
dask 46.09% <100.00%> (+0.19%) ⬆️
non-dask 69.25% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/feature_extraction/__init__.py 100.00% <100.00%> (ø)
python/cuml/feature_extraction/text.py 100.00% <100.00%> (ø)
python/cuml/dask/datasets/blobs.py 96.42% <0.00%> (-0.94%) ⬇️
python/cuml/comm/serialize.py 94.28% <0.00%> (-0.72%) ⬇️
python/cuml/common/input_utils.py 93.85% <0.00%> (ø)
python/cuml/experimental/common/__init__.py 100.00% <0.00%> (ø)
python/cuml/common/array.py 97.36% <0.00%> (+0.10%) ⬆️
python/cuml/common/memory_utils.py 85.32% <0.00%> (+2.97%) ⬆️
python/cuml/neighbors/kernel_density.py 82.89% <0.00%> (+7.23%) ⬆️
python/cuml/model_selection/_split.py 88.53% <0.00%> (+12.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@csadorf
Copy link
Contributor

csadorf commented Dec 15, 2022

@dantegd can you trigger the branch checker by updating the PR title, please?

@dantegd dantegd changed the title expose text, text.{CountVectorizer,HashingVectorizer,Tfidf{Transformer,Vectorizer}} from feature_extraction's public api expose text, text.{CountVectorizer,HashingVectorizer,Tfidf{Transformer,Vectorizer}} from feature_extraction's public api Dec 17, 2022
@dantegd
Copy link
Member

dantegd commented Dec 17, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7dcf2cf into rapidsai:branch-23.02 Dec 17, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
…r,Vectorizer}} from feature_extraction's public api (rapidsai#5028)

Authors:
  - Matthew Farrellee (https://github.com/mattf)

Approvers:
  - Carl Simon Adorf (https://github.com/csadorf)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#5028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Cython / Python Cython or Python issue doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants