Make doctest resilient to changes in cupy reprs #4945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
bug
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #4945 +/- ##
===============================================
Coverage ? 79.46%
===============================================
Files ? 183
Lines ? 11618
Branches ? 0
===============================================
Hits ? 9232
Misses ? 2386
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
wphicks
approved these changes
Oct 26, 2022
|
@gpucibot merge |
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Feb 27, 2023
Depending on the cupy package in use (varies by version, architecture, etc) the exact name of the `ndarray` object may be `cupy.ndarray` or something like `cupy._core.core.ndarray` instead. Using `isinstance` avoids doctest failures due to those sorts of instabilities. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - William Hicks (https://github.com/wphicks) URL: rapidsai#4945
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the cupy package in use (varies by version, architecture, etc) the exact name of the
ndarrayobject may becupy.ndarrayor something likecupy._core.core.ndarrayinstead. Usingisinstanceavoids doctest failures due to those sorts of instabilities.