[FIX] Use CPMFindPackage to retrieve cumlprims_mg
#4649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
changed the title
cumlprims_mg
trxcllnt
added
3 - Ready for Review
dantegd
approved these changes
Mar 23, 2022
robertmaynard
approved these changes
Mar 23, 2022
ajschmidt8
reviewed
Mar 24, 2022
This reverts commit 69329fc.
|
Looks like there's no |
|
rerun tests |
1 similar comment
|
rerun tests |
|
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #4649 +/- ##
===============================================
Coverage ? 83.86%
===============================================
Files ? 251
Lines ? 20307
Branches ? 0
===============================================
Hits ? 17030
Misses ? 3277
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Depends on rapidsai/raft#583 and rapidsai/cumlprims_mg#86 This PR includes a few fixes to support source-only builds: 1. Use `CPMFindPackage` to get `cumlprims_mg` a. This enables building against a local `cumlprims_mg` build (`-D cumlprims_mg_ROOT=/cumlprims_mg/cpp/build`) 2. Explicitly call `find_package(Threads)` to be more resilient to RAFT changes Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - Robert Maynard (https://github.com/robertmaynard) URL: rapidsai#4649
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on rapidsai/raft#583 and https://github.com/rapidsai/cumlprims_mg/pull/86
This PR includes a few fixes to support source-only builds:
CPMFindPackageto getcumlprims_mga. This enables building against a local
cumlprims_mgbuild (-D cumlprims_mg_ROOT=/cumlprims_mg/cpp/build)find_package(Threads)to be more resilient to RAFT changes