Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RAFT MM includes #4637

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Remove RAFT MM includes #4637

merged 2 commits into from
Mar 21, 2022

Conversation

viclafargue
Copy link
Contributor

No description provided.

@viclafargue viclafargue requested a review from a team as a code owner March 18, 2022 13:24
cjnolet
cjnolet approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just looks like a copyright needs updating.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 18, 2022
@viclafargue viclafargue changed the title Remove RAFT MR includes Remove RAFT MM includes Mar 18, 2022
@cjnolet
Copy link
Member

cjnolet commented Mar 18, 2022

rerun tests

3 similar comments
@cjnolet
Copy link
Member

cjnolet commented Mar 18, 2022

rerun tests

@viclafargue
Copy link
Contributor Author

rerun tests

@cjnolet
Copy link
Member

cjnolet commented Mar 21, 2022

rerun tests

@dantegd
Copy link
Member

dantegd commented Mar 21, 2022

@gpucibot merge

@dantegd dantegd mentioned this pull request Mar 21, 2022
Merged
@rapids-bot rapids-bot bot merged commit 3f54aec into rapidsai:branch-22.04 Mar 21, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@48120ce). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.04    #4637   +/-   ##
===============================================
  Coverage                ?   83.86%           
===============================================
  Files                   ?      251           
  Lines                   ?    20293           
  Branches                ?        0           
===============================================
  Hits                    ?    17018           
  Misses                  ?     3275           
  Partials                ?        0
Flag Coverage Δ
dask 44.92% <0.00%> (?)
non-dask 77.02% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48120ce...a0b7036. Read the comment docs.

vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@viclafargue
Remove RAFT MM includes (rapidsai#4637)
36def42 
Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viclafargue @cjnolet @dantegd @codecov-commenter