Adding docs for .get_feature_names() inside TfidfVectorizer
#4226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantegd
requested changes
Sep 24, 2021
Co-authored-by: Dante Gama Dessavre <[email protected]>
dantegd
approved these changes
Sep 24, 2021
dantegd
requested changes
Sep 24, 2021
| @@ -256,3 +256,13 @@ def transform(self, raw_documents): | |||
| """ | |||
| X = super().transform(raw_documents) | |||
| return self._tfidf.transform(X, copy=False) | |||
|
|
|||
| def get_feature_names(self): | |||
There was a problem hiding this comment.
Just after approving remembered that I forgot to ask, could you add a very simple pytest so that this method is covered?
|
rerun tests |
2 similar comments
|
rerun tests |
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #4226 +/- ##
================================================
+ Coverage 86.07% 86.09% +0.01%
================================================
Files 231 231
Lines 18649 18690 +41
================================================
+ Hits 16052 16091 +39
- Misses 2597 2599 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dantegd
approved these changes
Sep 27, 2021
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…dsai#4226) This PR resolves issue rapidsai#4219 by adding docs for `.get_feature_names()` in the `TfidfVectorizer` class. As mentioned in the linked issue, the method already exists in `CountVectorizer` and `TfidfVectorizer` inherits from that class, hence the functionality is present but not documented. Authors: - Mayank Anand (https://github.com/mayankanand007) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4226
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #4219 by adding docs for
.get_feature_names()in theTfidfVectorizerclass.As mentioned in the linked issue, the method already exists in
CountVectorizerandTfidfVectorizerinherits from that class, hence the functionality is present but not documented.