[REVIEW] Fixing UMAP reproducibility pytest failures in 11.4 by using random init for now #4152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #4152 +/- ##
===============================================
Coverage ? 85.96%
===============================================
Files ? 232
Lines ? 18500
Branches ? 0
===============================================
Hits ? 15904
Misses ? 2596
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Sorry for my slow progress. |
dantegd
approved these changes
Aug 11, 2021
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…nit for now (rapidsai#4152) This is side-stepping the spectral clustering bug for now. The spectral clustering using to be reproducible (and I'm fairly confident that it used to be returning the proper eigenpairs as well) but through various updates to the CTK, it seems to have gotten broken somewhere, potentially even in multiple places. Authors: - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is side-stepping the spectral clustering bug for now. The spectral clustering using to be reproducible (and I'm fairly confident that it used to be returning the proper eigenpairs as well) but through various updates to the CTK, it seems to have gotten broken somewhere, potentially even in multiple places.