Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Reducing cluster size to number of selected clusters. Returning stability scores #3987

Merged

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Jun 14, 2021

Addresses section 1 of #3879

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 14, 2021
@cjnolet cjnolet requested review from a team as code owners June 14, 2021 19:37
@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels Jun 14, 2021
@cjnolet cjnolet mentioned this pull request Jun 14, 2021
21 tasks
@cjnolet cjnolet changed the title [WIP] Reducing cluster size to number of selected clusters. Returning stability scores [REVIEW] Reducing cluster size to number of selected clusters. Returning stability scores Jun 15, 2021
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Corey!

@cjnolet
Copy link
Member Author

cjnolet commented Jun 15, 2021

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@48e3963). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #3987   +/-   ##
===============================================
  Coverage                ?   85.32%           
===============================================
  Files                   ?      230           
  Lines                   ?    18097           
  Branches                ?        0           
===============================================
  Hits                    ?    15441           
  Misses                  ?     2656           
  Partials                ?        0           
Flag Coverage Δ
dask 47.90% <0.00%> (?)
non-dask 77.67% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48e3963...6de2b09. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Jun 16, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit dc82e88 into rapidsai:branch-21.08 Jun 16, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants