Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] HDBSCAN: Lazy-loading (and caching) condensed & single-linkage tree objects #3986

Merged
merged 4 commits into from
Jun 16, 2021
Merged

[REVIEW] HDBSCAN: Lazy-loading (and caching) condensed & single-linkage tree objects #3986

merged 4 commits into from
Jun 16, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Jun 14, 2021

…ects

@cjnolet cjnolet added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 14, 2021
@cjnolet cjnolet requested a review from a team as a code owner June 14, 2021 15:52
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jun 14, 2021
@cjnolet cjnolet mentioned this pull request Jun 14, 2021
Open
21 tasks
dantegd
dantegd requested changes Jun 15, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks great, just had a question regarding the variable names (leading vs trailing underscore), unless I missed something we should keep the former naming scheme?

python/cuml/experimental/cluster/hdbscan.pyx Outdated Show resolved Hide resolved
python/cuml/experimental/cluster/hdbscan.pyx Outdated Show resolved Hide resolved
python/cuml/experimental/cluster/hdbscan.pyx Outdated Show resolved Hide resolved
@cjnolet
Copy link
Member Author

cjnolet commented Jun 15, 2021

rerun tests

@cjnolet cjnolet added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jun 16, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@8fe1b05). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #3986   +/-   ##
===============================================
  Coverage                ?   85.44%           
===============================================
  Files                   ?      230           
  Lines                   ?    18095           
  Branches                ?        0           
===============================================
  Hits                    ?    15461           
  Misses                  ?     2634           
  Partials                ?        0
Flag Coverage Δ
dask 47.90% <0.00%> (?)
non-dask 77.79% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fe1b05...92ea079. Read the comment docs.

dantegd
dantegd approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending conflict resolution from the other HDBSCAN PR

@cjnolet
Copy link
Member Author

cjnolet commented Jun 16, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit edecd3b into rapidsai:branch-21.08 Jun 16, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@cjnolet
HDBSCAN: Lazy-loading (and caching) condensed & single-linkage tree o…
56746fe 
…bjects (rapidsai#3986)

…ects

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjnolet @codecov-commenter @dantegd