-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Remove unused code in UMAP. #3931
[REVIEW] Remove unused code in UMAP. #3931
Conversation
trivialfis
commented
Jun 2, 2021
•
edited
Loading
edited
- Remove unused parameters in UMAP init.
- Remove unused function for extracting knn graph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM, however, I believe we will want to target this PR to branch-21.08.
Yup, it's moved into 08. I started the branch on 06 due to https://github.com/rapidsai/ops/issues/1610 . |
77aa1fa
to
cb0772b
Compare
Rebased onto 21.08. |
cb0772b
to
bc5e484
Compare
* Remove unused parameters in init. * Remove unused function in Python interface.
bc5e484
to
aedadbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #3931 +/- ##
===============================================
Coverage ? 85.32%
===============================================
Files ? 230
Lines ? 18093
Branches ? 0
===============================================
Hits ? 15437
Misses ? 2656
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@gpucibot merge |
* Remove unused parameters in UMAP init. * Remove unused function for extracting knn graph. Authors: - Jiaming Yuan (https://github.com/trivialfis) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#3931