-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix number of permutations in pytest and getting handle for cuml models #3920
Conversation
…at have handle as none
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Strange ARIMA cython build error in CI. Strange it's in a fresh environment though and in an unrelated PR:
|
I think it was bad timing, the arima PR got merged at a moment that made things fail, I think rerunning tests should be enough |
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #3920 +/- ##
===============================================
Coverage ? 85.19%
===============================================
Files ? 228
Lines ? 17928
Branches ? 0
===============================================
Hits ? 15273
Misses ? 2655
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@gpucibot merge |
…ls (rapidsai#3920) Closes rapidsai#3819 Bug fixes: - Increase npermutations in pytest (and reduce number of tests a bit), to avoid sporadic failure - Simplified code in common avoids a problem for cuML models that have handle as `none` (Naive Bayes) Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#3920
Closes #3819
Bug fixes:
none
(Naive Bayes)