-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade NCCL to 2.9.9 #3902
Upgrade NCCL to 2.9.9 #3902
Conversation
Looks like the CI failures here are related to recent Dask changes, which were recently fixed here? Going to rerun tests to see. |
rerun tests |
1 similar comment
rerun tests |
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swapping which one is dev installed
Co-authored-by: jakirkham <[email protected]>
Co-authored-by: jakirkham <[email protected]>
ci/gpu/build.sh
Outdated
gpuci_logger "Install the main version of dask and distributed" | ||
set -x | ||
pip install "git+https://github.com/dask/distributed.git@main" --upgrade --no-deps | ||
pip install "git+https://github.com/jakirkham/distributed.git@drop_whowhat_client" --upgrade --no-deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be reverted once ready as it is merged
pip install "git+https://github.com/jakirkham/distributed.git@drop_whowhat_client" --upgrade --no-deps | |
pip install "git+https://github.com/dask/distributed.git@main" --upgrade --no-deps |
Note: PR is waiting for an equivalent in integration |
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #3902 +/- ##
===============================================
Coverage ? 85.07%
===============================================
Files ? 228
Lines ? 17775
Branches ? 0
===============================================
Hits ? 15122
Misses ? 2653
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This change has been approved, is it good to go for the release? |
It's just waiting on rapidsai/integration#287 so that CI doesn't get issues after the merge |
@gpucibot merge |
Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Jordan Jacobelli (https://github.com/Ethyling) URL: rapidsai#3902
No description provided.