-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support sparse input features in QN solvers and Logistic Regression #3827
Support sparse input features in QN solvers and Logistic Regression #3827
Conversation
Add a wrapper required by rapidsai/cuml#3827 Authors: - Artem M. Chirkin (https://github.com/achirkin) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #220
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @achirkin for this PR! The internals look good, I have some small comments. I see that predict / decision function are not yet updated. I guess it make sense to converge on the common sparse / dense interface before implementing those.
Ugh, it seems I've hit the same issue as the one workarounded in #3679 . I've added the same "skip" statement for now, till we decide what to do with it. Interestingly, the test succeeds on my setup:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @achirkin for fixing the issues, the PR looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one quick comment about not needing to update the RAFT PIN for merging
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #3827 +/- ##
===============================================
Coverage ? 85.17%
===============================================
Files ? 228
Lines ? 17892
Branches ? 0
===============================================
Hits ? 15239
Misses ? 2653
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gpucibot merge |
…apidsai#3827) Allow input features tensor `X` to be sparse for the functions of a QN solver (logistic regression). Authors: - Artem M. Chirkin (https://github.com/achirkin) Approvers: - Tamas Bela Feher (https://github.com/tfeher) - Corey J. Nolet (https://github.com/cjnolet) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#3827
Allow input features tensor
X
to be sparse for the functions of a QN solver (logistic regression).