Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct deprecate positional args decorator for CalVer #3784

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Correct deprecate positional args decorator for CalVer #3784

merged 2 commits into from
Jun 1, 2021

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Apr 22, 2021

Closes #3751

@lowener lowener requested a review from a team as a code owner April 22, 2021 05:47
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Apr 22, 2021
@lowener lowener added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Apr 22, 2021
@dantegd dantegd requested a review from a team April 22, 2021 20:08
@dantegd
Copy link
Member

dantegd commented Apr 22, 2021

Requesting review from ops before approving

viclafargue
viclafargue approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

raydouglass
raydouglass previously requested changes Apr 23, 2021
View reviewed changes
Copy link
Member

@raydouglass raydouglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should hold off on this until Ops is ready to make the switch.

@dantegd dantegd added 0 - Blocked Cannot progress due to external reasons 2 - In Progress Currenty a work in progress and removed 3 - Ready for Review Ready for review by team 2 - In Progress Currenty a work in progress labels Apr 23, 2021
@ajschmidt8 ajschmidt8 added the improvement Improvement / enhancement to an existing function label Jun 1, 2021
@ajschmidt8 ajschmidt8 dismissed raydouglass’s stale review June 1, 2021 15:50

Ops has moved to calver. PR should be okay to merge pending other CODEOWNER reviews

@dantegd dantegd changed the title Switch version to 21.06 Switch version to 21.06 Jun 1, 2021
@dantegd
Copy link
Member

dantegd commented Jun 1, 2021

rerun tests

1 similar comment
@dantegd
Copy link
Member

dantegd commented Jun 1, 2021

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@c05d7a2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #3784   +/-   ##
===============================================
  Coverage                ?   85.17%           
===============================================
  Files                   ?      228           
  Lines                   ?    17933           
  Branches                ?        0           
===============================================
  Hits                    ?    15274           
  Misses                  ?     2659           
  Partials                ?        0
Flag Coverage Δ
dask 47.81% <0.00%> (?)
non-dask 77.44% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c05d7a2...58c1c1d. Read the comment docs.

@dantegd dantegd changed the title Switch version to 21.06 Correct deprécate positional args decorator for CalVer Jun 1, 2021
@dantegd dantegd changed the title Correct deprécate positional args decorator for CalVer Correct deprecate positional args decorator for CalVer Jun 1, 2021
@dantegd
Copy link
Member

dantegd commented Jun 1, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b30d527 into rapidsai:branch-21.06 Jun 1, 2021
@lowener lowener deleted the 020-switch-21.06 branch June 2, 2021 13:38
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@lowener
Correct deprecate positional args decorator for CalVer (rapidsai#3784)
ad02d2f 
Closes rapidsai#3751

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Victor Lafargue (https://github.com/viclafargue)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viclafargue viclafargue viclafargue approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@dantegd dantegd dantegd approved these changes

@raydouglass raydouglass raydouglass left review comments

Assignees
No one assigned
Labels
0 - Blocked Cannot progress due to external reasons Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Prep for CalVer, eliminate all references to 0.20 in source
6 participants
@lowener @dantegd @codecov-commenter @raydouglass @ajschmidt8 @viclafargue