-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Fixing umap gtest failure under cuda 11.2. #3696
[REVIEW] Fixing umap gtest failure under cuda 11.2. #3696
Conversation
This also depends on rapidsai/raft#193 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this, great fix! Forgot about atomics... sorry for this.
@@ -36,7 +36,8 @@ namespace Spectral { | |||
* @param out output array for embedding (size n*n_comonents) | |||
*/ | |||
void fit_embedding(const raft::handle_t &handle, int *rows, int *cols, | |||
float *vals, int nnz, int n, int n_components, float *out); | |||
float *vals, int nnz, int n, int n_components, float *out, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to leave a comment that one CI job showed a small doxygen issue, so that it doesn't block things later:
Generating docs for c/workspace/cpp/include/cuml/cluster/spectral.hpp:38: error: The following parameter of
ML::Spectral::fit_embedding(const raft::handle_t &handle, int *rows, int *cols, float *vals, int nnz, int n, int n_components, float
*out, unsigned long long seed=1234567) is not documented:
17:47:37 parameter 'seed' (warning treated as error, aborting now)
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #3696 +/- ##
===============================================
+ Coverage 80.70% 83.02% +2.31%
===============================================
Files 227 227
Lines 17615 17712 +97
===============================================
+ Hits 14217 14706 +489
+ Misses 3398 3006 -392
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Conflicts: cpp/cmake/Dependencies.cmake
@gpucibot merge |
Closes #3406.
There's a couple things to note in this PR: