Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix Codecov.io Coverage Upload for Branch Builds #3524

Merged

Conversation

mdemoret-nv
Copy link
Contributor

@mdemoret-nv mdemoret-nv commented Feb 18, 2021

Testing the following undocumented option:

codecov:
  allow_coverage_offsets: true

Suggested by Codecov.io support here to fix the linked issue with missing base reports.

@mdemoret-nv mdemoret-nv added bug Something isn't working 2 - In Progress Currenty a work in progress tests Unit testing for project non-breaking Non-breaking change labels Feb 18, 2021
@mdemoret-nv
Copy link
Contributor Author

rerun tests

@mdemoret-nv mdemoret-nv requested a review from a team as a code owner February 19, 2021 23:40
@github-actions github-actions bot added the gpuCI gpuCI issue label Feb 19, 2021
@codecov-io
Copy link

Codecov Report

Merging #3524 (c1bdcb4) into branch-0.19 (39c7262) will increase coverage by 7.56%.
The diff coverage is 71.72%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #3524      +/-   ##
===============================================
+ Coverage        71.77%   79.34%   +7.56%     
===============================================
  Files              212      225      +13     
  Lines            17075    17946     +871     
===============================================
+ Hits             12256    14239    +1983     
+ Misses            4819     3707    -1112     
Flag Coverage Δ
dask 44.12% <14.67%> (?)
non-dask 71.62% <69.97%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/cuml/_thirdparty/sklearn/preprocessing/_data.py 63.61% <ø> (+0.07%) ⬆️
python/cuml/experimental/explainer/common.py 88.05% <42.85%> (-4.01%) ⬇️
...l/_thirdparty/sklearn/preprocessing/_imputation.py 62.40% <50.00%> (-0.11%) ⬇️
python/cuml/neighbors/nearest_neighbors.pyx 92.43% <50.00%> (-0.29%) ⬇️
python/cuml/neighbors/ann.pyx 61.62% <61.62%> (ø)
python/cuml/common/import_utils.py 59.43% <66.66%> (+3.43%) ⬆️
python/cuml/experimental/explainer/base.pyx 67.06% <67.06%> (ø)
python/cuml/dask/common/utils.py 43.68% <83.33%> (+16.13%) ⬆️
python/cuml/experimental/explainer/kernel_shap.pyx 97.75% <100.00%> (+0.48%) ⬆️
...n/cuml/experimental/explainer/permutation_shap.pyx 98.82% <100.00%> (+0.84%) ⬆️
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 430593d...c1bdcb4. Read the comment docs.

@mdemoret-nv mdemoret-nv changed the title [WIP] Fix Codecov.io "Missing Base Report" Issue [REVIEW] Fix Codecov.io Coverage Upload for Branch Builds Feb 23, 2021
@mdemoret-nv
Copy link
Contributor Author

Changing this PRs focus from fixing the missing base report to fixing coverage upload for branch builds. Branch build coverage will be necessary to fix missing base reports. Therefore this PR needs to be merged before we can see any effect.

@mdemoret-nv mdemoret-nv added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Feb 23, 2021
Copy link
Contributor

@JohnZed JohnZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnZed
Copy link
Contributor

JohnZed commented Feb 24, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6dfff66 into rapidsai:branch-0.19 Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working gpuCI gpuCI issue non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants