Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non project-flash CI ml test 18.04 issue debugging and bugfixing #3495

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Feb 12, 2021

PR does a small change for non project FLASH path of the ci/gpu/build.sh script. We were observing a linking bug in the test/ml executable only when it was being executed in the Ubuntu 18.04 containers (see https://gpuci.gpuopenanalytics.com/view/RAPIDS%20-%20GPU%20Matrix/job/rapidsai/job/gpuci/job/cuml/job/branches/job/cuml-gpu-matrix-branch-0.18/)

This PR works around the bug for that particular situation by letting LD_LIBRARY_PATH contain the conda lib folder up to the point of execution of test/ml, and does not affect regular project FLASH PR CI.

@dantegd dantegd added bug Something isn't working 2 - In Progress Currenty a work in progress gpuCI gpuCI issue non-breaking Non-breaking change labels Feb 12, 2021
@dantegd dantegd requested a review from a team as a code owner February 12, 2021 17:25
@github-actions github-actions bot added the Ops label Feb 12, 2021
@ajschmidt8
Copy link
Member

hey @dantegd. is this PR for testing? or will it be merged? If it's going to be merged, can you update the description to reflect the changes that were made? thanks!

@dantegd dantegd added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Feb 16, 2021
@dantegd
Copy link
Member Author

dantegd commented Feb 16, 2021

@ajschmidt8 will update the description in a second, it is for a nightly CI test failure that @raydouglass spotted in the Ubuntu 18.04 container in the test matrix

@dantegd
Copy link
Member Author

dantegd commented Feb 16, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e60b101 into rapidsai:branch-0.18 Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working gpuCI gpuCI issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants