Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing sparse NN test in CI by allowing small number of index discrepancies #3454

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Fix failing sparse NN test in CI by allowing small number of index discrepancies #3454

merged 2 commits into from
Feb 3, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 3, 2021

Closes #3449

@cjnolet cjnolet added bug Something isn't working 3 - Ready for Review Ready for review by team tests Unit testing for project non-breaking Non-breaking change labels Feb 3, 2021
@cjnolet cjnolet requested a review from a team as a code owner February 3, 2021 17:14
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 3, 2021
wphicks
wphicks approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo in the comments, but otherwise this looks good. Logic is sound, and the solution makes sense.

python/cuml/test/test_nearest_neighbors.py Outdated Show resolved Hide resolved
@JohnZed
Copy link
Contributor

JohnZed commented Feb 3, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d69f08c into rapidsai:branch-0.18 Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@wphicks wphicks wphicks approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] CI errors for for sparse knn w/ minkowski distances
4 participants
@cjnolet @JohnZed @dantegd @wphicks