Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Mark kbinsdiscretizer quantile tests as xfail #3450

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Feb 3, 2021

Mark kbinsdiscretizer quantile tests as xfail to avoid cupy/cupy#4607

Mark kbinsdiscretizer quantile tests as xfail to avoid cupy/cupy#4607
@wphicks wphicks added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Feb 3, 2021
@wphicks wphicks requested a review from a team as a code owner February 3, 2021 00:07
@wphicks wphicks requested a review from JohnZed February 3, 2021 00:08
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 3, 2021
@wphicks
Copy link
Contributor Author

wphicks commented Feb 3, 2021

Full details here: #2933

Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent use of pytest parameters.

@codecov-io
Copy link

Codecov Report

Merging #3450 (9eefcec) into branch-0.18 (550121b) will increase coverage by 0.22%.
The diff coverage is 86.02%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #3450      +/-   ##
===============================================
+ Coverage        71.48%   71.71%   +0.22%     
===============================================
  Files              207      212       +5     
  Lines            16748    17059     +311     
===============================================
+ Hits             11973    12234     +261     
- Misses            4775     4825      +50     
Impacted Files Coverage Δ
python/cuml/datasets/classification.py 80.80% <ø> (+0.19%) ⬆️
python/cuml/decomposition/incremental_pca.py 94.70% <ø> (ø)
python/cuml/preprocessing/model_selection.py 100.00% <ø> (+9.64%) ⬆️
python/cuml/svm/svc.pyx 95.16% <ø> (-0.62%) ⬇️
python/cuml/svm/svm_base.pyx 94.27% <ø> (-0.63%) ⬇️
python/cuml/dask/ensemble/base.py 20.27% <12.50%> (+0.95%) ⬆️
python/cuml/dask/cluster/kmeans.py 54.00% <33.33%> (ø)
python/cuml/dask/decomposition/base.py 39.53% <50.00%> (ø)
...ython/cuml/dask/ensemble/randomforestclassifier.py 30.00% <50.00%> (+0.51%) ⬆️
python/cuml/dask/ensemble/randomforestregressor.py 35.08% <50.00%> (+0.54%) ⬆️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb1c810...9eefcec. Read the comment docs.

@JohnZed
Copy link
Contributor

JohnZed commented Feb 3, 2021

@gpucibot merge

@wphicks
Copy link
Contributor Author

wphicks commented Feb 3, 2021

Hit by silhouette score flaky test.

@wphicks
Copy link
Contributor Author

wphicks commented Feb 3, 2021

rerun tests

3 similar comments
@JohnZed
Copy link
Contributor

JohnZed commented Feb 3, 2021

rerun tests

@wphicks
Copy link
Contributor Author

wphicks commented Feb 4, 2021

rerun tests

@JohnZed
Copy link
Contributor

JohnZed commented Feb 4, 2021

rerun tests

@rapids-bot rapids-bot bot merged commit a01a55d into rapidsai:branch-0.18 Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants