Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review] Parallelize RF to Treelite conversion over trees #3395

Merged
merged 5 commits into from
Jan 22, 2021

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Jan 21, 2021

Perform construction of Treelite trees in parallel when converting from a cuML RF model
Improve speed of initial prediction for a model with 300 trees of approximately 4M nodes by an average of 2.04x on a system with 12 Intel Xeon Gold 6128 CPUs available

@wphicks wphicks requested a review from a team as a code owner January 21, 2021 18:42
@wphicks wphicks added feature request New feature or request non-breaking Non-breaking change labels Jan 21, 2021
@wphicks
Copy link
Contributor Author

wphicks commented Jan 21, 2021

Related to issue #2399 (first of several)

@wphicks wphicks added the 3 - Ready for Review Ready for review by team label Jan 21, 2021
@wphicks wphicks changed the title Parallelize RF to Treelite conversion over trees [Review] Parallelize RF to Treelite conversion over trees Jan 21, 2021
@codecov-io
Copy link

Codecov Report

Merging #3395 (5db8773) into branch-0.18 (550121b) will increase coverage by 0.14%.
The diff coverage is 85.77%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #3395      +/-   ##
===============================================
+ Coverage        71.48%   71.63%   +0.14%     
===============================================
  Files              207      210       +3     
  Lines            16748    16924     +176     
===============================================
+ Hits             11973    12123     +150     
- Misses            4775     4801      +26     
Impacted Files Coverage Δ
python/cuml/decomposition/incremental_pca.py 94.70% <ø> (ø)
python/cuml/dask/ensemble/base.py 19.69% <30.43%> (+0.36%) ⬆️
python/cuml/ensemble/randomforestregressor.pyx 70.83% <44.44%> (ø)
...ython/cuml/dask/ensemble/randomforestclassifier.py 30.00% <50.00%> (+0.51%) ⬆️
python/cuml/dask/ensemble/randomforestregressor.py 35.08% <50.00%> (+0.54%) ⬆️
python/cuml/fil/fil.pyx 91.87% <60.00%> (-1.88%) ⬇️
python/cuml/ensemble/randomforestclassifier.pyx 73.72% <66.66%> (ø)
python/cuml/multiclass/multiclass.py 84.21% <84.21%> (ø)
python/cuml/model_selection/_split.py 90.35% <90.35%> (ø)
python/cuml/svm/svm_base.pyx 94.27% <91.30%> (-0.63%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c48f35a...5db8773. Read the comment docs.

@wphicks wphicks added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jan 22, 2021
@JohnZed
Copy link
Contributor

JohnZed commented Jan 22, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4ce2380 into rapidsai:branch-0.18 Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request libcuml non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants