Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ANN memory release bug #3391

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

viclafargue
Copy link
Contributor

@viclafargue viclafargue commented Jan 20, 2021

Answers #3318
This may fix the error observed in CI.

Before the change, the memory manager handler was released first, then the FAISS index.
After the change, the FAISS index is released first, then the memory manager handler is released.

@viclafargue viclafargue added breaking Breaking change bug Something isn't working labels Jan 20, 2021
@JohnZed
Copy link
Contributor

JohnZed commented Jan 20, 2021

Original error not reproducing but there was an error in fetch_20newsgroups (zlib compression error)

@JohnZed
Copy link
Contributor

JohnZed commented Jan 20, 2021

rerun tests

@codecov-io
Copy link

codecov-io commented Jan 21, 2021

Codecov Report

Merging #3391 (14396bc) into branch-0.18 (550121b) will increase coverage by 0.14%.
The diff coverage is 85.77%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #3391      +/-   ##
===============================================
+ Coverage        71.48%   71.63%   +0.14%     
===============================================
  Files              207      210       +3     
  Lines            16748    16924     +176     
===============================================
+ Hits             11973    12123     +150     
- Misses            4775     4801      +26     
Impacted Files Coverage Δ
python/cuml/decomposition/incremental_pca.py 94.70% <ø> (ø)
python/cuml/dask/ensemble/base.py 19.69% <30.43%> (+0.36%) ⬆️
python/cuml/ensemble/randomforestregressor.pyx 70.83% <44.44%> (ø)
...ython/cuml/dask/ensemble/randomforestclassifier.py 30.00% <50.00%> (+0.51%) ⬆️
python/cuml/dask/ensemble/randomforestregressor.py 35.08% <50.00%> (+0.54%) ⬆️
python/cuml/fil/fil.pyx 91.87% <60.00%> (-1.88%) ⬇️
python/cuml/ensemble/randomforestclassifier.pyx 73.72% <66.66%> (ø)
python/cuml/multiclass/multiclass.py 84.21% <84.21%> (ø)
python/cuml/model_selection/_split.py 90.35% <90.35%> (ø)
python/cuml/svm/svm_base.pyx 94.27% <91.30%> (-0.63%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 816bb65...14396bc. Read the comment docs.

@JohnZed
Copy link
Contributor

JohnZed commented Jan 21, 2021

rerun tests

@viclafargue
Copy link
Contributor Author

rerun tests

@viclafargue viclafargue added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed breaking Breaking change improvement Improvement / enhancement to an existing function labels Jan 21, 2021
@JohnZed JohnZed changed the title [WIP] Fix for ANN memory release bug Fix for ANN memory release bug Jan 21, 2021
@JohnZed JohnZed marked this pull request as ready for review January 21, 2021 17:12
@JohnZed JohnZed requested a review from a team as a code owner January 21, 2021 17:12
@JohnZed
Copy link
Contributor

JohnZed commented Jan 21, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e8d1610 into rapidsai:branch-0.18 Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcuml non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants