Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] genetic programming initial structures #3387

Conversation

teju85
Copy link
Member

@teju85 teju85 commented Jan 20, 2021

This PR introduces/proposes some of the basic and core (gpu-friendly!) data structures for implementing gplearn in cuML in order to address the issue #2121 .

Tagging all who will be involved in this development: @vinaydes @venkywonka @vimarsh6739.

PS: It also contains an experimental register-based stack implementation that will be useful while implementing CUDA-based AST evaluation, which is needed for organizing tournaments.

@teju85 teju85 requested review from a team as code owners January 20, 2021 03:51
@teju85 teju85 added non-breaking Non-breaking change CUDA / C++ CUDA issue New Algorithm For tracking new algorithms that will be added to our existing collection 3 - Ready for Review Ready for review by team and removed CMake libcuml labels Jan 20, 2021
@teju85 teju85 added the feature request New feature or request label Jan 21, 2021
@cjnolet cjnolet self-requested a review January 26, 2021 15:17
@cjnolet
Copy link
Member

cjnolet commented Feb 2, 2021

rerun tests

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending successful CI

@cjnolet
Copy link
Member

cjnolet commented Feb 2, 2021

@teju85, this looks like it needs copyrights updated. Otherwise, I think it's ready to go.

@teju85
Copy link
Member Author

teju85 commented Feb 3, 2021

Thanks @cjnolet I have fixed the copyright errors.

@cjnolet
Copy link
Member

cjnolet commented Feb 3, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9196252 into rapidsai:branch-0.18 Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CUDA / C++ CUDA issue feature request New feature or request libcuml New Algorithm For tracking new algorithms that will be added to our existing collection non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants