Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add float64 warning when loading LightGBM model #2874

Merged
merged 2 commits into from
Sep 26, 2020

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Sep 25, 2020

No description provided.

@wphicks wphicks requested a review from a team as a code owner September 25, 2020 22:12
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@wphicks
Copy link
Contributor Author

wphicks commented Sep 25, 2020

Resolve #2817.

I spent a little bit of time trying to understand whether there were other places in the code we could intercept uses of load_using_treelite_handle or load_from_treelite_model and offer warnings, but I didn't see anywhere that really made sense to do so. Do we think it is worth adding warnings directly to those methods indicating that there may be an issue even if we can't reliably detect if there will be an issue?

Otherwise, this change is pretty darn simple. Anything more sophisticated will probably have to wait on the Treelite update.

@wphicks wphicks changed the title [Review] Add float64 warning when loading LightGBM model [REVIEW] Add float64 warning when loading LightGBM model Sep 25, 2020
@wphicks
Copy link
Contributor Author

wphicks commented Sep 25, 2020

@hcho3 and/or @JohnZed: If you wouldn't mind reviewing this, it would be much appreciated.

Copy link
Contributor

@hcho3 hcho3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the best we can do without updating Treelite module in cuML.

@dantegd dantegd merged commit fae1cba into rapidsai:branch-0.16 Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants