[REVIEW] Enable clang tidy on cuML c++ sources #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ea-ext-clang-tidy
…ea-ext-clang-tidy
teju85
changed the title
teju85
changed the title
|
@JohnZed I have resolved the issues and gotten the |
…ea-ext-clang-tidy
JohnZed
reviewed
May 12, 2020
JohnZed
approved these changes
May 12, 2020
raydouglass
requested changes
May 12, 2020
…ea-ext-clang-tidy
raydouglass
approved these changes
May 13, 2020
|
rerun tests |
|
Thanks @raydouglass. Seems like this doesn't allow merging without @mike-wendt 's approval too. Can get one @mike-wendt ? |
mike-wendt
suggested changes
May 15, 2020
mike-wendt
approved these changes
May 19, 2020
7 tasks
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Jan 20, 2022
This PR is adding clang-tidy to cudf and adding the initial checks. Note more checks will be enabled in the future. Relevant PRs: * `rmm`: rapidsai/rmm#857 * `cuml`: rapidsai/cuml#1945 To do list: * [x] Add `.clang-tidy` file * [x] Add python script * [x] Apply `modernize-` changes * [x] Revert `cxxopts` changes * [x] Fixed Python parquet failures * [x] Ignore `cxxopts` file * [x] Ignore the `build/_deps` directories Splitting out the following into a separate PR so we can get the changes merged for 22.02 (#10064): * ~~[ ] Disable `clang-diagnostic-errors/warnings`~~ * ~~[ ] Fix include files being skipped~~ * ~~[ ] Set up CI script~~ * ~~[ ] Clean up python script~~ Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - Bradley Dice (https://github.com/bdice) - Nghia Truong (https://github.com/ttnghia) - David Wendt (https://github.com/davidwendt) - Mark Harris (https://github.com/harrism) - Vyas Ramasubramani (https://github.com/vyasr) URL: #9860
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run-clang-tidy.pywrapper script to invoke tidy checks on all compilation targets in the compilation database generated by cmakecompile_commands.jsonfile from cmake, by default.Currently, not yet enabled the checks on .cu source files due to some wierd setup issues I'm facing. Hoping to fix those in the coming days.
@dantegd in order to enable this check from inside
ci/checks/style.sh, I'll need to have runcmakebefore (in order to generate compilation database). But runningcmakefromstyle.shwill only cause the errors that are currently happening in PR #1931. Please suggest the right place (and the right way) in our CI to enable this check.