Skip to content

Commit

Permalink
Use HDBSCAN package pin to 0.8.38 (#5906)
Browse files Browse the repository at this point in the history
HBSCAN has a [breaking change](scikit-learn-contrib/hdbscan@aa99a71) in `main` branch, which cause wheel nightly tests to fail as cuML picks up HDBSCAN from `main` branch HEAD. As HDBSCAN also releases on pypi now, we can install release packages instead of installing HDBSCAN from git source.

This PR also updates HBDSCAN to v0.8.38.

Authors:
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - https://github.com/jakirkham

URL: #5906
  • Loading branch information
divyegala authored Aug 15, 2024
1 parent 7df3bbd commit c7f53ef
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 10 deletions.
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-118_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ dependencies:
- doxygen=1.9.1
- gcc_linux-64=11.*
- graphviz
- hdbscan<=0.8.30
- hdbscan>=0.8.38,<0.8.39
- hypothesis>=6.0,<7
- ipykernel
- ipython
Expand Down
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-125_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ dependencies:
- doxygen=1.9.1
- gcc_linux-64=11.*
- graphviz
- hdbscan<=0.8.30
- hdbscan>=0.8.38,<0.8.39
- hypothesis>=6.0,<7
- ipykernel
- ipython
Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/cuml-cpu/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ requirements:
- numpy>=1.23,<2.0a0
- pandas
- scikit-learn=1.2
- hdbscan<=0.8.30
- hdbscan>=0.8.38,<0.8.39
- umap-learn=0.5.3
- nvtx

Expand Down
9 changes: 3 additions & 6 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ dependencies:
common:
- output_types: [conda, requirements, pyproject]
packages:
- cython>=3.0.0
- &cython cython>=3.0.0
- &treelite treelite==4.3.0
- output_types: conda
packages:
Expand Down Expand Up @@ -486,7 +486,9 @@ dependencies:
common:
- output_types: [conda, requirements, pyproject]
packages:
- *cython
- dask-ml
- hdbscan>=0.8.38,<0.8.39
- hypothesis>=6.0,<7
- nltk
- numpydoc
Expand All @@ -505,14 +507,9 @@ dependencies:
- pip
- pip:
- dask-glm==0.3.0
# TODO: remove pin once a release that includes fixes for the error
# is released: https://github.com/rapidsai/cuml/issues/5514
- hdbscan<=0.8.30
- output_types: pyproject
packages:
- dask-glm==0.3.0
# TODO: Can we stop pulling from the master branch now that there was a release in October?
- hdbscan @ git+https://github.com/scikit-learn-contrib/hdbscan.git@master
test_notebooks:
common:
- output_types: [conda, requirements]
Expand Down
3 changes: 2 additions & 1 deletion python/cuml/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,10 @@ classifiers = [

[project.optional-dependencies]
test = [
"cython>=3.0.0",
"dask-glm==0.3.0",
"dask-ml",
"hdbscan @ git+https://github.com/scikit-learn-contrib/hdbscan.git@master",
"hdbscan>=0.8.38,<0.8.39",
"hypothesis>=6.0,<7",
"nltk",
"numpydoc",
Expand Down

0 comments on commit c7f53ef

Please sign in to comment.