Apply suggestions from code review

Co-authored-by: Bradley Dice <[email protected]>
rapidsai · Jul 11, 2023 · b3cee15 · b3cee15
1 parent 325e954
commit b3cee15
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 12 deletions.
diff --git a/conda/recipes/cuml/conda_build_config.yaml b/conda/recipes/cuml/conda_build_config.yaml
@@ -16,11 +16,9 @@ cmake_version:
 sysroot_version:
   - "=2.17"
 
-# CUDA 11 versions
-
-# The CTK libraries below are missing from the conda-forge::cudatoolkit
-# package. The "*_host_*" version specifiers correspond to `11.8` packages and the
-# "*_run_*" version specifiers correspond to `11.x` packages.
+# The CTK libraries below are missing from the conda-forge::cudatoolkit package
+# for CUDA 11. The "*_host_*" version specifiers correspond to `11.8` packages
+# and the "*_run_*" version specifiers correspond to `11.x` packages.
 
 cuda11_libcublas_host_version:
   - "=11.11.3.6"

diff --git a/conda/recipes/libcuml/conda_build_config.yaml b/conda/recipes/libcuml/conda_build_config.yaml
@@ -22,11 +22,9 @@ treelite_version:
 gtest_version:
   - ">=1.13.0"
 
-# CUDA 11 versions
-
-# The CTK libraries below are missing from the conda-forge::cudatoolkit
-# package. The "*_host_*" version specifiers correspond to `11.8` packages and the
-# "*_run_*" version specifiers correspond to `11.x` packages.
+# The CTK libraries below are missing from the conda-forge::cudatoolkit package
+# for CUDA 11. The "*_host_*" version specifiers correspond to `11.8` packages
+# and the "*_run_*" version specifiers correspond to `11.x` packages.
 
 cuda11_libcublas_host_version:
   - "=11.11.3.6"

diff --git a/conda/recipes/libcuml/meta.yaml b/conda/recipes/libcuml/meta.yaml
@@ -50,7 +50,7 @@ requirements:
   host:
     - cuda-version ={{ cuda_version }}
     {% if cuda_major == "11" %}
-    - cudatoolkit ={{ cuda_version }}
+    - cudatoolkit
     - libcublas {{ cuda11_libcublas_host_version }}
     - libcublas-dev {{ cuda11_libcublas_host_version }}
     - libcufft {{ cuda11_libcufft_host_version }}

diff --git a/dependencies.yaml b/dependencies.yaml
@@ -126,7 +126,8 @@ dependencies:
               arch: x86_64
               cuda: "12.0"
             packages:
-              - cuda-nvcc=12.0
+              - cuda-nvcc
+              - cuda-version=12.0
   py_build:
     common:
       - output_types: [conda, requirements, pyproject]
@@ -200,6 +201,7 @@ dependencies:
               - cuda-cudart-dev
               - cuda-profiler-api
               - libcublas-dev
+              - libcufft-dev
               - libcurand-dev
               - libcusolver-dev
               - libcusparse-dev