-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward-merge branch-24.06 into branch-24.08 #4476
Conversation
Addresses #4474 Currently `openmpi=5.0.3-hfd7b305_105` is blocking our CI `cpp_build` job. Most likely introduced by this PR: conda-forge/openmpi-feedstock#158 This PR will unblock cugraph development until the issues are fixed. Once that happens, the version pinning should be removed.
FAILURE - Unable to forward-merge due to an error, manual merge is necessary. Do not use the IMPORTANT: When merging this PR, do not use the auto-merger (i.e. the |
PyTorch 2.2+ is incompatible with the NCCL version on our containers. Normally, this would not be an issue, but there is a bug in CuPy that loads the system NCCL instead of the user NCCL. This PR binds the PyTorch test dependency version to get around this issue. --------- Co-authored-by: Bradley Dice <[email protected]> Co-authored-by: Ralph Liu <[email protected]> Co-authored-by: James Lamb <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## branch-24.08 #4476 +/- ##
===============================================
Coverage ? 65.41%
===============================================
Files ? 217
Lines ? 14875
Branches ? 0
===============================================
Hits ? 9731
Misses ? 5144
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Replaces #4476 Authors: - Ralph Liu (https://github.com/nv-rliu) - Alex Barghi (https://github.com/alexbarghi-nv) - Tingyu Wang (https://github.com/tingyu66) - Bradley Dice (https://github.com/bdice) - James Lamb (https://github.com/jameslamb) Approvers: - Alex Barghi (https://github.com/alexbarghi-nv) - Chuck Hastings (https://github.com/ChuckHastings) - Bradley Dice (https://github.com/bdice) URL: #4489
@raydouglass Can this be closed now that #4489 has been merged? |
Forward-merge triggered by push to branch-24.06 that creates a PR to keep branch-24.08 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.