-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define heterogeneous renumbering API #4463
Define heterogeneous renumbering API #4463
Conversation
…to fea_heterogeneous_renumbering_api
@alexbarghi-nv In heterogeneous renumbering, can I assume that vertex types are always used? Or there can be a use case with no vertex type but just edge types? Similarly, is there a use case with vertex types but no edge types & IDs? (i.e. should the input |
It is safe to assume that if there are edge types, then there are also vertex types, and vice versa. |
This looks good to me. I had a long question typed out about compression, but then my tab crashed and I lost it. Anyways, we can worry about compression later. This API looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Because the performance gain of CSR format is pretty small for PyG, I think implementing this function is sufficient for our 24.08 goals for heterogeneous renumbering. |
/merge |
Defines a heterogeneous renumbering function that renumbers sampled edge list vertex & edge IDs to consecutive integers per vertex & edge type, respectively.
The renumbered edges are sorted. New functions that sort & compress will be added later.