Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary 'setuptools' and 'wheel' dependencies #4448

Merged
merged 2 commits into from
May 30, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented May 28, 2024

Contributes to rapidsai/build-planning#62.

It looks like the cugraph and pylibcugraph wheels and conda recipes have unnecessary dependencies on setuptools and wheel. I suspect those are left over from before those libraries were cut over to scikit-build-core.

This proposes removing those.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Notes for Reviewers

How I confirmed there were no direct uses of setuptools in cugraph and pylibcugraph:

git grep -i setuptools

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 28, 2024
@BradReesWork BradReesWork added this to the 24.08 milestone May 28, 2024
@jameslamb jameslamb changed the title WIP: remove unnecessary 'setuptools' and 'wheel' dependencies remove unnecessary 'setuptools' and 'wheel' dependencies May 29, 2024
@jameslamb jameslamb marked this pull request as ready for review May 29, 2024 14:17
@jameslamb jameslamb requested review from a team as code owners May 29, 2024 14:17
@jameslamb
Copy link
Member Author

/merge

@jameslamb
Copy link
Member Author

/merge

Oh my bad, missed that this needs a review from a Python codeowner.

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rapids-bot rapids-bot bot merged commit ee4cbb7 into rapidsai:branch-24.08 May 30, 2024
140 checks passed
@jameslamb jameslamb deleted the remove-setuptools branch May 30, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants