Expose graph_view method to count multi edges through C API and PLC #4426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
improvement
seunghwak
approved these changes
May 16, 2024
jnke2016
approved these changes
May 17, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python property graph class does some expensive dask calls to determine if a graph is a multi-graph.
This PR exposes to the C API and the PLC layer the graph_view method that counts the number of multi-edges in the graph. Specifically, the function returns the number of extra edges exist. So if the edge
(u,v)existsktimes, that edge contributesk-1to the return value.If the return value of this function is greater than 0 then the graph is a multi-graph. If the return value is 0 then while the graph might be labeled a multi-graph, there are no multi-edges so it could be treated as a graph.
Closes #2417
Note that the property graph python code would still need to be modified to use this function.