Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNMG Approximation Algorithm for the Weighted Matching Problem #4315

Merged
merged 21 commits into from
May 21, 2024
Merged

MNMG Approximation Algorithm for the Weighted Matching Problem #4315

merged 21 commits into from
May 21, 2024

Conversation

naimnv
Copy link
Contributor

@naimnv naimnv commented Apr 4, 2024 •
edited by ChuckHastings
Loading

@naimnv naimnv requested review from a team as code owners April 4, 2024 00:39
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 4, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@naimnv naimnv changed the base branch from branch-24.04 to branch-24.06 April 4, 2024 00:41
@naimnv naimnv self-assigned this Apr 4, 2024
@naimnv naimnv added this to the 24.06 milestone Apr 4, 2024
@naimnv naimnv added feature request New feature or request non-breaking Non-breaking change labels Apr 4, 2024
seunghwak
seunghwak reviewed Apr 10, 2024
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need C++ tests as well.

cpp/include/cugraph/algorithms.hpp Outdated Show resolved Hide resolved
cpp/include/cugraph/algorithms.hpp Outdated Show resolved Hide resolved
cpp/src/community/matching_impl.cuh Outdated Show resolved Hide resolved
cpp/src/community/matching_impl.cuh Outdated Show resolved Hide resolved
cpp/src/community/matching_impl.cuh Outdated Show resolved Hide resolved
cpp/src/community/matching_impl.cuh Outdated Show resolved Hide resolved
@naimnv
Copy link
Contributor Author

naimnv commented Apr 16, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented Apr 16, 2024

@ChuckHastings @seunghwak It's ready for a re-review.

@ChuckHastings
Copy link
Collaborator

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented Apr 17, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented May 14, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented May 14, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented May 14, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented May 14, 2024 •
edited
Loading

@seunghwak it's read for a final review. I tested the code on dgx machine with 8 GPUs.

@naimnv
Copy link
Contributor Author

naimnv commented May 15, 2024

/okay to test

seunghwak
seunghwak approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naimnv
Copy link
Contributor Author

naimnv commented May 20, 2024

/okay to test

@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit 2779f32 into rapidsai:branch-24.06 May 21, 2024
131 of 132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

Assignees

@naimnv naimnv

Labels
CMake cuGraph feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
24.06
Development

Successfully merging this pull request may close these issues.

Implement MNMG Weighted Matching approximation algorithm
3 participants
@naimnv @ChuckHastings @seunghwak