-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Several MG Tests #4244
Merged
rapids-bot
merged 31 commits into
rapidsai:branch-24.06
from
nv-rliu:b2406-mg-test-improvements
May 14, 2024
Merged
Refactor Several MG Tests #4244
rapids-bot
merged 31 commits into
rapidsai:branch-24.06
from
nv-rliu:b2406-mg-test-improvements
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for mentioning me, Ralph! :) I did a rough review and please find it above. It’s so great to see nice and clean code coming in! |
rlratzel
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for all the cleanup!
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
python
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4187
This PR makes improvements to old MG testing conventions used in these testing directories:
The goals of this PR is to improve readability and use of the MG tests. Changes are similar to #4197
By using the Datasets API (which now supports MG Graphs thanks to @huiyuxie), the number of imports and
testing.utils
functions can be significantly reduced.