Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nx-cugraph: use coverage to ensure all algorithms were run #4108

Merged
merged 18 commits into from
Feb 1, 2024
Merged

nx-cugraph: use coverage to ensure all algorithms were run #4108

merged 18 commits into from
Feb 1, 2024

Conversation

eriknw
Copy link
Contributor

@eriknw eriknw commented Jan 23, 2024 •
edited
Loading

Heh, there is probably a "better" way to do this, but this way was fast and easy enough to do, and I hope is "good enough".

@eriknw eriknw requested review from a team as code owners January 23, 2024 02:40
rlratzel
rlratzel approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the quick response for this. I was actually poking around with something similar but mine was based on examining the output of coverage annotate and I wasn't feeling too good about it, so let's go with this approach :)

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 23, 2024
@BradReesWork BradReesWork added this to the 24.02 milestone Jan 23, 2024
@rlratzel
Copy link
Contributor

rlratzel commented Feb 1, 2024

/merge

@rapids-bot rapids-bot bot merged commit 20f7dca into rapidsai:branch-24.02 Feb 1, 2024
109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
24.02
Development

Successfully merging this pull request may close these issues.
4 participants
@eriknw @rlratzel @raydouglass @BradReesWork