Mtmg updates for rmm #4031
Merged
Mtmg updates for rmm #4031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
improvement
seunghwak
reviewed
Dec 1, 2023
| @@ -524,6 +524,7 @@ std::tuple<size_t, rmm::device_uvector<uint32_t>> mark_entries(raft::handle_t co | |||
| return word; | |||
| }); | |||
|
|
|||
| // FIXME: use detail::count_set_bits | |||
There was a problem hiding this comment.
Any reason to defer this update? (https://github.com/rapidsai/cugraph/blob/branch-24.02/cpp/include/cugraph/utilities/mask_utils.cuh#L109)
There was a problem hiding this comment.
I have another PR ready to stage right after this where I've made this change.
seunghwak
approved these changes
Dec 1, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered RAII capabilities in RMM while reviewing issues related to MTMG testing. This PR modifies the MTMG implementation to use the RAII capabilities for setting the device id temporarily to another device.